[R4R]-fix: N-04 public Functions Can Be Declared as external (#130)

Co-authored-by: Ivan Wang <ivan.wang@mantle.xyz>
mantlenetworkio · Mar 6, 2024 · c923b01 · c923b01
1 parent 8fa40a6
commit c923b01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/contracts-bedrock/contracts/L2/GasPriceOracle.sol b/packages/contracts-bedrock/contracts/L2/GasPriceOracle.sol
@@ -59,7 +59,7 @@ contract GasPriceOracle is Semver {
     * @param _operator New operator
      */
     // slither-disable-next-line external-function
-    function setOperator(address _operator) public onlyOwner {
+    function setOperator(address _operator) external onlyOwner {
         address previousOperator = operator;
         operator = _operator;
         emit OperatorUpdated(previousOperator, operator);
@@ -69,7 +69,7 @@ contract GasPriceOracle is Semver {
      * @dev Transfers ownership of the contract to a new account (`_owner`).
      * Can only be called by the current owner.
      */
-    function transferOwnership(address _owner) public onlyOwner {
+    function transferOwnership(address _owner) external onlyOwner {
         require(_owner != address(0), "new owner is the zero address");
         address previousOwner = owner;
         owner = _owner;
@@ -81,7 +81,7 @@ contract GasPriceOracle is Semver {
     * @param _tokenRatio New tokenRatio
      */
     // slither-disable-next-line external-function
-    function setTokenRatio(uint256 _tokenRatio) public onlyOperator {
+    function setTokenRatio(uint256 _tokenRatio) external onlyOperator {
         uint256 previousTokenRatio = _tokenRatio;
         tokenRatio = _tokenRatio;
         emit TokenRatioUpdated(previousTokenRatio, tokenRatio);

diff --git a/packages/contracts-bedrock/contracts/deployment/PortalSender.sol b/packages/contracts-bedrock/contracts/deployment/PortalSender.sol
@@ -26,7 +26,7 @@ contract PortalSender {
      * @notice Sends balance of this contract to the OptimismPortal.
                 on the Mantle Mainnet, this function will donate ETH and MNT
      */
-    function donate() public {
+    function donate() external {
         uint256 totalAmount = IERC20(PORTAL.L1_MNT_ADDRESS()).balanceOf(address(this));
         bool succ = IERC20(PORTAL.L1_MNT_ADDRESS()).transfer(address(PORTAL),totalAmount);
         require(succ,"donate mnt failed");