Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]: Migrate some methods from universal to implements #11

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

Ethanncnm
Copy link
Contributor

@Ethanncnm Ethanncnm commented Sep 6, 2023

Base on original optimism contract, we just change some methods in StandardBridge and CrossDomainMessage to virtual, and override these methods in L1StandardBridge, L2StandardBridge, L1CrossDomainMessage and L2CrossDomainMessage.

In later PRs, we just need to update these override methods, thus we won't be confused about what is msg.value represents to. In L1StandardBridge and L1CrossDomainMessage, msg.value represents ETH token. In L2StandardBridge and L2CrossDomainMessage, msg.value represents MNT token.

@abelliumnt abelliumnt changed the title update bridge contract [R4R]: update bridge contract Sep 6, 2023
@Sha3nS
Copy link
Contributor

Sha3nS commented Sep 6, 2023

migrate some method from universal to implements
LGTM

@abelliumnt abelliumnt changed the title [R4R]: update bridge contract [R4R]: Migrate some methods from universal to implements Sep 6, 2023
@Ethanncnm Ethanncnm merged commit 1fd7ffc into develop Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants