R4R: increate relay reserved gas for additional erc20 approve #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: increate relay reserved gas for additional erc20 approve
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
abelliumnt
changed the title
asdv23
approved these changes
Mar 1, 2024
I tested the execution cost of 'approve' in the code, and it's around 12000. |
Tri-stone
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://etherscan.io/tx/0x002adc343f6af457d6ff1f7391850517461b866ca52e95268f637054da457711/advanced
Each approve costs approximate 50000 gas. So here, the reserved gas is increased 100000.