Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] N-01 Typographical Errors #124

Merged
merged 2 commits into from
Mar 6, 2024
Merged

[R4R] N-01 Typographical Errors #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0506013
style: N-01 Typographical Errors
DevDynamo2024 Mar 5, 2024
c59af08
style: N-01 Typographical Errors
DevDynamo2024 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions op-batcher/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ type Metrics struct {
info prometheus.GaugeVec
up prometheus.Gauge

// label by openend, closed, fully_submitted, timed_out
// label by opened, closed, fully_submitted, timed_out
channelEvs opmetrics.EventVec

pendingBlocksCount prometheus.GaugeVec
Expand Down Expand Up @@ -272,7 +272,7 @@ const (
TxStageFailed = "failed"

TxInitDataSubmitted = "init_data_submitted"
TxConfirmDataSubmiited = "confirm_data_submitted"
TxConfirmDataSubmitted = "confirm_data_submitted"
TxInitDataSuccess = "init_data_success"
TxConfirmDataSuccess = "confirm_data_success"
TxInitDataFailed = "init_data_failed"
Expand Down Expand Up @@ -373,7 +373,7 @@ func (m *Metrics) RecordBatchTxInitDataFailed() {
}

func (m *Metrics) RecordBatchTxConfirmDataSubmitted() {
m.batcherTxEvs.Record(TxConfirmDataSubmiited)
m.batcherTxEvs.Record(TxConfirmDataSubmitted)
}

func (m *Metrics) RecordBatchTxConfirmDataSuccess() {
Expand Down
2 changes: 1 addition & 1 deletion op-chain-ops/genesis/setters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func setProxies(db vm.StateDB, proxyAdminAddr common.Address, namespace *big.Int
}

for i := uint64(0); i <= count; i++ {
// ignore dev L1's L1_MANTLE_TOEKN address for 0x6900000000000000000000000000000000000020 and the 20 for hexadecimal means 32 in 10 hex.
// ignore dev L1's L1_MANTLE_TOKEN address for 0x6900000000000000000000000000000000000020 and the 20 for hexadecimal means 32 in 10 hex.
if i == uint64(32) && namespace == bigL1PredeployNamespace {
bigAddr := new(big.Int).Or(namespace, new(big.Int).SetUint64(i))
addr := common.BigToAddress(bigAddr)
Expand Down