R4R: implement migration tool for mantle bedrock #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelliumnt
changed the title
byteflyfunny
previously approved these changes
Oct 13, 2023
guoshijiang
reviewed
Oct 13, 2023
Ethanncnm
reviewed
Oct 16, 2023
added 2 commits
October 16, 2023 14:42
guoshijiang
previously approved these changes
Oct 17, 2023
Tri-stone
reviewed
Oct 17, 2023
| @@ -234,7 +234,7 @@ func findCrossDomainMessage(receipt *types.Receipt) (*crossdomain.CrossDomainMes | |||
| // Parse the new extension event | |||
| if event.Name == "SentMessageExtension1" { | |||
| e, _ := l2xdm.ParseSentMessageExtension1(*log) | |||
| msg.Value = e.Value | |||
| msg.EthValue = e.EthValue | |||
There was a problem hiding this comment.
use EthValue and ETHValue in different lines, maybe prefer ETHValue and MNTValue
There was a problem hiding this comment.
EthValue is defined in https://github.com/mantlenetworkio/op-geth/pull/1/files. I can't rename it to ETHValue
Sha3nS
reviewed
Oct 18, 2023
abelliumnt
force-pushed
the
feature/migration-tool
branch
from
c661252
to
253359e
Compare
Tri-stone
approved these changes
Oct 18, 2023
Sha3nS
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested the migration tool in local devnet bedrock uggrade.