-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R4R]: gas-oracle hsm sign support #55
Conversation
Ran 109 test suites: 531 tests passed😊, 0 failed😂, 0 skipped (531 total tests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// log.Crit("gasoracle", "create signer error", err.Error()) | ||
// return nil, err | ||
//} | ||
seqBytes, err := hex.DecodeString(cfg.HsmCreden) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing err handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
gas-oracle/oracle/token_ratio.go
Outdated
opts, err = mk.NewEthereumTransactorWithChainID(context.Background(), cfg.l2ChainID) | ||
if err != nil { | ||
log.Crit("gasoracle", "create signer error", err.Error()) | ||
return nil, err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func Crit(msg string, ctx ...interface{}) {
root.write(msg, LvlCrit, ctx, skipLevel)
os.Exit(1)
}
log.Crit
will abort the current program. return
doesn't make sense here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleted
Ran 109 test suites: 531 tests passed😊, 0 failed😂, 0 skipped (531 total tests) |
Core changes: