Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R] - {sdk}: align standard-bridge with selected chain #1268

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

grezle
Copy link
Contributor

@grezle grezle commented Jul 10, 2023

Goals of PR

Core changes:

  • Defines a mapping between L1_MNT_ADDRESS and L2_CHAIN_ID so that we can check against the correct MNT address in the standard-bridge.

@github-actions github-actions bot added the M-sdk label Jul 10, 2023
shellteo
shellteo previously approved these changes Jul 11, 2023
Copy link
Contributor

@shellteo shellteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shellteo shellteo changed the title fix(mantle-sdk): align standard-bridge with selected chain [R4R] - {sdk}: align standard-bridge with selected chain Jul 11, 2023
@Tri-stone
Copy link
Collaborator

Thank you very much for your contribution. Please refer to our contributing guide and make your PR to develop. @grezle

@grezle grezle changed the base branch from main to develop July 11, 2023 12:26
@grezle grezle dismissed shellteo’s stale review July 11, 2023 12:26

The base branch was changed.

@grezle grezle requested a review from wukongcheng as a code owner July 11, 2023 12:26
@grezle grezle force-pushed the bugfix/fix-bridge-support branch from e9d180b to 3edac44 Compare July 11, 2023 12:28
@grezle grezle force-pushed the bugfix/fix-bridge-support branch from 3edac44 to 7bd8cef Compare July 16, 2023 01:33
@Sha3nS Sha3nS merged commit eb5506b into mantlenetworkio:develop Jul 20, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants