Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]-{mt-batcher}: log optimization for mt-batcher and da-retriever #1329

Merged
merged 2 commits into from
Aug 8, 2023
Merged

[R4R]-{mt-batcher}: log optimization for mt-batcher and da-retriever #1329

merged 2 commits into from
Aug 8, 2023

Conversation

guoshijiang
Copy link
Contributor

@guoshijiang guoshijiang commented Aug 3, 2023 •
edited
Loading

Goals of PR

Core changes:

There are many invalid logs in mt-batcher and da-retriever

  • mt-batcher will take up 60G of elasticsearch disk space every day.
  • da-retriever will take up 4G of elasticsearch disk space every day.

Therefore, log optimization is required

Notes:

  • no

Related Issues:

@guoshijiang guoshijiang changed the title log optimization for mt-batcher [R4R]-{develop}: log optimization for mt-batcher Aug 3, 2023
@guoshijiang guoshijiang changed the title [R4R]-{develop}: log optimization for mt-batcher [R4R]-{develop}: log optimization for mt-batcher and da-retriever Aug 3, 2023
@guoshijiang guoshijiang changed the title [R4R]-{develop}: log optimization for mt-batcher and da-retriever [R4R]-{mt-batcher}-{develop}: log optimization for mt-batcher and da-retriever Aug 3, 2023
@guoshijiang guoshijiang changed the title [R4R]-{mt-batcher}-{develop}: log optimization for mt-batcher and da-retriever [R4R]-{mt-batcher}: log optimization for mt-batcher and da-retriever Aug 3, 2023
Tri-stone
Tri-stone approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@Tri-stone Tri-stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sha3nS
Copy link
Collaborator

Sha3nS commented Aug 4, 2023

LGTM

@guoshijiang guoshijiang merged commit 2562dab into develop Aug 8, 2023
1 of 6 checks passed
@guoshijiang guoshijiang deleted the feature/log-optimization branch August 8, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wukongcheng wukongcheng wukongcheng approved these changes

@byteflyfunny byteflyfunny byteflyfunny approved these changes

@Tri-stone Tri-stone Tri-stone approved these changes

@Ethanncnm Ethanncnm Ethanncnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@guoshijiang @Sha3nS @wukongcheng @byteflyfunny @Tri-stone @Ethanncnm