R4R: implement meta transaction #2
Conversation
abelliumnt
force-pushed
the
feature/meta-tx
branch
4 times, most recently
from
ef17bcb
to
b58bdaf
Compare
abelliumnt
changed the title
abelliumnt
requested review from
wukongcheng,
byteflyfunny,
Tri-stone,
guoshijiang,
Sha3nS and
Ethanncnm
| if metaTxParams == nil { | ||
| continue | ||
| } | ||
| if metaTxParams.ExpireHeight < currHeight { |
There was a problem hiding this comment.
What is the purpose of metaTxParams.ExpireHeight?
There was a problem hiding this comment.
The gas fee sponsor have no idea about when the users will submit meta transactions. Suppose the gas fee sponsor don't want to sponsor gas fee any more, and want to use the wallet in the future, it would be possible that sponsor wallet will be deducted native token in the future, which will be very confusing. With the ExpireHeight, the sponsor can ensure that there will be no unconscious deduction after the highest ExpireHeight.
In summary, the ExpireHeight can bring more determinism for the fee sponsor.
core/txpool/txpool.go
Outdated
| if metaTxParams.ExpireHeight < pool.chain.CurrentBlock().Number.Uint64() { | ||
| return types.ErrExpiredMetaTx | ||
| } | ||
| balance = pool.currentState.GetBalance(metaTxParams.GasFeeSponsor) |
There was a problem hiding this comment.
What happens when there is not enough balance in st.msg. MetaTxParams. GasFeeSponsor
There was a problem hiding this comment.
In line 706, balance will be checked against tx cost.
abelliumnt
force-pushed
the
feature/meta-tx
branch
2 times, most recently
from
44b716c
to
07feb74
Compare
abelliumnt
changed the title
|
Try to support gas fee sponsor percent. |
abelliumnt
force-pushed
the
feature/meta-tx
branch
4 times, most recently
from
18dc64c
to
1d2aac1
Compare
refacor implementation and add unittests
refactor code bug fix
remove expired metatx fix nil pointer issue
add unittest in txpool to conver meta tx
improve unittests
add more tests refactor util
abelliumnt
force-pushed
the
feature/meta-tx
branch
from
1d2aac1
to
5ed7682
Compare
abelliumnt
changed the title
This PR enable mantle-v2 to natively support meta transaction(gas less. transaction) in protocol.
There are other gasless transaction protocols which don't need any changes in protocol, such as
https://eips.ethereum.org/EIPS/eip-2771
https://eips.ethereum.org/EIPS/eip-2612
However, all above gas less transaction protocols have some limitations on either user accounts or assets contracts, which is not convenient.
Tools to build and broadcast meta tx:
metatx.zip