[R4R]-[fee]feat: fee collection with tokenRatio #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tri-stone
changed the title
abelliumnt
reviewed
Nov 10, 2023
abelliumnt
reviewed
Nov 10, 2023
abelliumnt
reviewed
Nov 10, 2023
byteflyfunny
previously approved these changes
Nov 21, 2023
byteflyfunny
previously approved these changes
Nov 22, 2023
abelliumnt
reviewed
Nov 23, 2023
core/vm/runtime/runtime.go
Outdated
| @@ -74,7 +74,9 @@ func setDefaults(cfg *Config) { | |||
| cfg.Difficulty = new(big.Int) | |||
| } | |||
| if cfg.GasLimit == 0 { | |||
| cfg.GasLimit = math.MaxUint64 | |||
| // todo: leo | |||
| // cfg.GasLimit = math.MaxUint64 | |||
There was a problem hiding this comment.
resolved, delete the todo directly.
abelliumnt
reviewed
Nov 23, 2023
| type RunMode uint8 | ||
|
|
||
| const ( | ||
| CommitMode RunMode = iota |
There was a problem hiding this comment.
Please assign CommitMode to RunMode in function TransactionToMessage. Not a bug. It is strange that CommitMode is never used.
There was a problem hiding this comment.
fixed, set default RunMode as CommitMode
abelliumnt
reviewed
Nov 27, 2023
| @@ -499,7 +531,7 @@ func (rs Receipts) DeriveFields(config *params.ChainConfig, hash common.Hash, nu | |||
| // Deriving the signer is expensive, only do if it's actually needed | |||
| from, _ := Sender(signer, txs[i]) | |||
| nonce := txs[i].Nonce() | |||
| if rs[i].DepositNonce != nil { | |||
| if txs[i].IsDepositTx() && rs[i].DepositNonce != nil { | |||
There was a problem hiding this comment.
txs[i].IsDepositTx() seems to be not necessary.
There was a problem hiding this comment.
We changes the way to store DepositNonce, so the DepositNonce will not be nil and the default value will be 0 for non-depositTxs, so add txs[i].IsDepositTx() to determine the tx type.
abelliumnt
reviewed
Nov 27, 2023
|
No other comment |
abelliumnt
approved these changes
Nov 29, 2023
byteflyfunny
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core changes:
tokenRatiofrom GasPriceOracleL1 Rollup Fee&L2 Execution FeeReleated PR: