feat: Add ESLINT_D_MAX_INSTANCES env variable. (#201) #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson28
reviewed
Feb 16, 2023
|
Really looking forward to this. Any blocker that can be removed here? |
|
@uloco Thanks for offering help. This will need test cases and the validation should happen when starting the server so that we can log to stderr or fail. Currently this happens inside of the daemon and the error isn't shown. |
|
I'll see what I can do thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey I left this branch on my local machine and figured I'd just push it. This resolves #201 by adding an environment variable to configure the max instances so it can be reduced/increased from 10.
It just needs some help getting the error logging working. I can't print to std out. Would you be able to help me with this?