Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other web player #35

Open
4 of 7 tasks
mantou132 opened this issue Jul 23, 2020 · 27 comments
Open
4 of 7 tasks

Support other web player #35

mantou132 opened this issue Jul 23, 2020 · 27 comments
Labels
enhancement New feature or request

Comments

@mantou132
Copy link
Owner

mantou132 commented Jul 23, 2020

If there are other excellent Web Players(PWA), the extension can also be adapted.

  • Youtebe Music
  • Apple Music
  • Deezer
  • Tidal
  • Pandora
  • Amazon Music
  • Joox

// Also need a suitable name, e.g: lyrics widget

Ways to support other players:

  1. edit manifest.json content_scripts
  2. edit config.ts currentPlatform and localConfig
  3. edit config.json

screenshot3 copy

@mantou132 mantou132 added the enhancement New feature or request label Jul 23, 2020
mantou132 added a commit that referenced this issue Jul 25, 2020
mantou132 added a commit that referenced this issue Jul 25, 2020
mantou132 added a commit that referenced this issue Jul 25, 2020
@mantou132 mantou132 reopened this Jul 25, 2020
@mantou132 mantou132 pinned this issue Jul 25, 2020
@homamgamer
Copy link

youtube.com?

@mantou132
Copy link
Owner Author

@homamgamer This extension uses the song name and artist to search for lyrics. It is foreseeable that YouTube’s lyrics match rate will be low

In other words, this extension is only suitable for music players

@homamgamer
Copy link

you can still figure out a way around it, you just have to work harder

@homamgamer
Copy link

for example, you have this addon that can look for lyrics for youtube videos
I've used it and it works well but it searches for lyrics from different providers
also take a look at this
This

@MFRehan
Copy link

MFRehan commented Aug 28, 2020

Hi @mantou132 ,
Thank for this great extension, I think It would be nice if you add support for Deezer too.

@mantou132
Copy link
Owner Author

@MFRehan It seems to be easy to support, but only Deezer Premium can play a full-length track

Annotation 2020-08-29 114656

@mantou132
Copy link
Owner Author

mantou132 commented Sep 11, 2020

@MFRehan v1.5 should support Deezer, but currently I only test it under a free account.

And will remove the native lyrics feature

Screenshot 2020-09-12 065123

@MFRehan
Copy link

MFRehan commented Nov 24, 2020

@mantou132 Great, Thank you for the great effort!

@lostfilm
Copy link

Support https://listen.tidal.com/ please.

@mantou132
Copy link
Owner Author

@lostfilm It seems that Tidal is a very suitable webapp. But it cannot be used in my area, so I cannot log in to debug.

@Louissenny
Copy link

@mantou132 As a tidal user, I will be happy if I can help you test it. 😉

@skeletclique
Copy link

also it would be perfect for apple music web

@mantou132
Copy link
Owner Author

@Louissenny v1.5.10 support TIDAL, But I don’t have a complete test, there may be a bug.

@mantou132
Copy link
Owner Author

@dimivell Apple music is a very good service, but their web client is really bad, I will consider it again in the future

@Louissenny
Copy link

@mantou132 thanks a lot! I will check it out later and tell you if there's any bugs. Once again thank you for your work!

@skeletclique
Copy link

@mantou132 thank you for the consideration i think it would satisfy a lot of apple products owners who have windows laptops and can't listen to apple music (itunes has been discontinued and it lags a lot)

@Louissenny
Copy link

Louissenny commented Dec 3, 2020

@mantou132 Hey, I've been using it for couple hours, here are some feedbacks:

For TIDAL: It works on both Chrome and Edge, fails to work on Chrome Dev due to unknown reasons (Maybe Chrome Dev has some limitations). And there's a bug: every time when a song is ended and the next song kicks in, the lyrics stuck on the end of the last song and becomes irresponsive, even if I click other songs it stays the same. This happens on both PIP and page mode, only gets back to normal if I refresh the webapp. It won't happen if I manually skip a song or select a song everytime.

For YouTube Music: As long as the extension is on the webpage goes dark, happens on Chrome, Chrome Dev and Edge, as you can see from the picture below. After I switched the extension off it gets back to normal. I've tried with different network conditions and it's all the same. I guess YouTube has some sort of detecting methods.
image

Again I want to shout out to your wonderful work in such a short amount of time 👍 your extension really is the best of its kind (at least for TIDAL users, lol) thank you so much

@mantou132
Copy link
Owner Author

@Louissenny Thank you for the test. I can’t log in to TIDAL and YouTube Music right now, so these issues cannot be fixed yet.

@Louissenny
Copy link

@mantou132 No problem. Please take your time ; )

@mantou132
Copy link
Owner Author

@Louissenny I just released v1.5.12 and v1.5.13, trying to fix the bugs of YouTube music and tidal respectively

@Louissenny
Copy link

@mantou132 thanks for the work, seems like you stayed up late last night.
I tried both versions on Chrome and Edge, and unfortunately the problem with TIDAL is still there. The lyrics won't switch to the next song automatically and stays irresponsive. And there seems to be a new bug: the album cover fails to load now, happens under several network conditions:
(with extension)
with
(without extension, under the same network)
without

As for YouTube Music, it works now but face a similar problem with TIDAL, when the song automatically switches to next one the lyrics becomes unsynchronized with the song or stops showing. It won't happen when I manually select or switch the song. I guess this is due to either songs on YTM has different duration (esp. for those with a music video) or YTM has a weird setting: it won't wait until a song is fully ended and switches early.

P.S.: If you want I can give you my TIDAL and YTM accounts for you to debug, feel free to ask me, it's not a big deal ; )

@mantou132
Copy link
Owner Author

@dimivell I tried to add lyrics to apple music, but apple music has strict restrictions and cannot access the lyrics server. I haven't found a way to break through the restrictions.

@skeletclique
Copy link

@mantou132 i understand thank you very much for trying i hope they make it easier at some point

@skeletclique
Copy link

skeletclique commented Dec 10, 2020

hey @mantou132 there is this webplayer that is alternative to apple music web player.. https://musi.sh/ could the extension work for this website? it has its own lyrics but i prefer your extension

@mantou132
Copy link
Owner Author

mantou132 commented Dec 12, 2020

@skeletclique v1.5.14 support apple music.

@skeletclique
Copy link

@mantou132 works great although pause and play buttons dont work as sometimes lyrics and cover don't load too

@iamlawy14
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants