Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify publish producer record method - remove unused topic argument #111

Merged
merged 1 commit into from
Apr 8, 2018
Merged

Simplify publish producer record method - remove unused topic argument #111

merged 1 commit into from
Apr 8, 2018

Conversation

lashchenko
Copy link
Contributor

I have found that the topic argument have never been used in the publishToKafka(ProducerRecord) method. This is expected, because the topic is available in the ProducerRecord.

@tjheslin1
Copy link
Contributor

Good spot 👍

@manub manub merged commit aa350db into manub:master Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lashchenko @tjheslin1 @manub