Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove log4j and slf4j #124

Closed
wants to merge 2 commits into from
Closed

Remove log4j and slf4j #124

wants to merge 2 commits into from

Conversation

francescopellegrini
Copy link
Contributor

Completes the work started in the obsolete remove_log4j branch.

@manub
Copy link
Owner

manub commented Apr 30, 2018

Are you sure this doesn't pull log4j as a transitive dependency from Kafka to whoever uses this library?

@francescopellegrini
Copy link
Contributor Author

It surely does.
This raises a question: why bother excluding slf4j-log4j12 in the first place? I'm closing this PR and opening another one to better explain what I mean.

@francescopellegrini francescopellegrini deleted the remove-log4j-and-slf4j branch May 2, 2018 08:39
@francescopellegrini
Copy link
Contributor Author

See #127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francescopellegrini @manub