#337 Set default timeout on ISBN search. #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhimmel
reviewed
Jul 15, 2022
manubot/cite/isbn.py
Outdated
Comment on lines
19
to
22
| import isbnlib | ||
|
|
||
| isbnlib.config.setthreadstimeout(seconds=timeout_seconds) | ||
| isbnlib.config.seturlopentimeout(seconds=timeout_seconds) |
There was a problem hiding this comment.
slight preference for us to define a helper like import_isbnlib such that we don't have to repeat this configuration 3 times.
There was a problem hiding this comment.
Is a helper preferable to using only a global import and config for the library at the top of the module?
This is an ISBN getting module anyway.
There was a problem hiding this comment.
Is a helper preferable to using only a global import and config for the library at the top of the module?
Usually not, although in this case let's assume we added the lazy importing of isbnlib for a reason and keep it that way.
There was a problem hiding this comment.
@xihh87 did you want to switch this to use a helper so we can merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've reduced the scope of changes on #338 as requested:
This change is only configurable on source code in the global variable defined on isbn search file.