Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use github.event context for DEFAULT_BRANCH #452

Merged
merged 2 commits into from Dec 3, 2021

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Nov 30, 2021

Updates method added in #399. See commit notes from 667d170 on references for the old method. I believe github.event.repository.default_branch did not exist when we initially implemented this.

One benefit is this removes a bash command that does not work on macos due to an old grep. Running CI on macos or windows is helpful for prototyping our environment.

References

@dhimmel
Copy link
Member Author

dhimmel commented Dec 2, 2021

This won't work for scheduled jobs, since scheduled jobs are missing the github.event.repository.fork context.

@dhimmel dhimmel merged commit 0703e8e into manubot:main Dec 3, 2021
@dhimmel dhimmel deleted the actions-default-branch branch December 3, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant