Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Newtonsoft.Json package references to 12.0.2 #72

Conversation

HenrikNergaard-INS
Copy link

No description provided.

@HenrikNergaard-INS
Copy link
Author

@manuc66
It looks like your sonar token is no longer valid.

At line:2 char:5
+     SonarScanner.MSBuild.exe begin /k:"manuc66:JsonSubtypes" /d:"sona ...
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (The format of t...gin= is invalid:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
The format of the analysis property sonar.github.oauth= is invalid

@manuc66
Copy link
Owner

manuc66 commented May 9, 2019

@HenrikNergaard-INS in fact it can not be decrypted from a build coming from a Pull request of another appveyor user because of the encrypted value here :

secure: XUib5rF8Uxwk7S2umtsFEQ9t5G0p/J3G3PNpWLZuNIyw/zNufLDCge8C6QJRTzQw

I don't know how to fix that without exposing the token publicly which is something I don't want (I you know how to fix that, you're welcome ;-)).

So don't bother with this error...

<ItemGroup>
<None Include="..\LICENSE">
<Pack>True</Pack>
<PackagePath></PackagePath>
</None>
</ItemGroup>
<ItemGroup>
<PackageReference Include="Newtonsoft.Json" Version="12.0.2" />
Copy link
Owner

@manuc66 manuc66 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Floating versions should only be used for patch versions, maybe minor versions, but not major ones. From the documentation:
The Nearest Wins rule can result in a downgrade of the package version, thus potentially breaking other dependencies in the graph. Hence this rule is applied with a warning to alert the user.

Newtonsoft adds both bugfixes and new features in patch versions so I do not think it is a good idea to wildcard patch versions for this dependency.
https://github.com/JamesNK/Newtonsoft.Json/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants