Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added System Tray and Notifications #19

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Conversation

NellyAngelz
Copy link
Collaborator

Added the system tray which was in the TODO, also fixed the app quitting after entering the client_id (due to using int() instead of str())
when building you must move the icon to the root directory of the build or it will throw an error when running the RPC.

NellyAngelz and others added 4 commits August 31, 2023 07:15
-- Quit functionality working as expected
-- Hide/Show functionality working perfectly (tested on windows 11)
-- Now the app will attempt to open conhost directly (required for hiding and showing the console)
-- Fixed crashing after the first setup
-- If settings.json file is invalid it will delete it for you.
@NellyAngelz
Copy link
Collaborator Author

hey @manucabral please review this pull request. I added the feature from your TODO and added a notification that pop up when a new song is detected. I also implemented opening conhost directly to fix windows 11 Show/Hide Console issue. since windows 11 defaults to using the new windows terminal I made it kill windows terminal and start conhost directly which fixed the issue. this should also work for windows 10, but since I don't have a PC running windows 10 I'd like you to verify that yourself. there's a comment next to the kill command, move /IM cmd.exe behind /F and that should kill the cmd window the first instance opened in

@NellyAngelz
Copy link
Collaborator Author

and don't forget to release a new release please, the current release is 4 versions behind. make sure to include icon.ico in the root folder of the new release after running the build command to avoid the file not found error

-- It can now download icon.ico file from my website if icon.ico is not found
-- Fixed minor path issue with the notifications
Copy link
Owner

@manucabral manucabral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks for include the system tray.
Today I will be uploading the new version. I will make some final tweaks for the build, and of course, you will be included in the developers credits.

@manucabral manucabral merged commit 628c54d into manucabral:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants