refactor: change to const instead of let and use short circuit

manudevelopia · Jul 23, 2019 · 2591d4c · 2591d4c
1 parent 57dec04
commit 2591d4c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/main/js/components/CompoundsForm.tsx b/src/main/js/components/CompoundsForm.tsx
@@ -14,7 +14,7 @@ export class CompoundsForm extends React.Component<any, any> {
   }
 
   public render() {
-    const spinner = this.state.generatingReport ? <Spinner size="sm" color="light"/> : '';
+    const spinner = this.state.generatingReport && <Spinner size="sm" color="light"/>;
 
     let compounds = this.props.selection.map((compound: any, index: number) => {
         return <tr key={index}>
@@ -67,7 +67,7 @@ export class CompoundsForm extends React.Component<any, any> {
   }
 
   private removeFromSelected(index: number) {
-    let results = this.state.compounds.slice();
+    const results = this.state.compounds.slice();
 
     results.splice(this.state.compounds[index], 1);
     this.setState({compounds: results});

diff --git a/src/main/js/components/search/Search.tsx b/src/main/js/components/search/Search.tsx
@@ -32,7 +32,7 @@ export class Search extends React.Component<any, any> {
 
   render() {
 
-    const spinner = this.state.searching ? <Spinner size="sm" color="light"/> : '';
+    const spinner = this.state.searching && <Spinner size="sm" color="light"/>;
 
     return (
       <Row>