Mods to elevation and async service #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
your elevation request from the server with client_id and private_key
Conflicts: geolib.js
|
These features require an update to the googlemaps module. We will resubmit this pull request when that is published to the latest version. |
how we were calculating it. Works now.
Uses config instead of setBusinessSpecificParameters.
|
googleMaps updated. Looks better. Plz publish to npm. |
|
I have made some major improvements to the library so that your changes cannot be merged automatically. Could you pull and re-implement your changes again? I will then publish your changes to npm as soon as everything is merged and tested. |
Conflicts: geolib.js geolib.min.js package.json tests/geolib.test.html
When comparing distances between two lat/lngs geolib was returning a different distance than google was. Google is using haversine formula to get their distances. It is a much easier equation and simpler to read.
Haversine for getDistance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some improvements and additions.