Skip to content

Commit

Permalink
[dvbviewer] 64bit channel ids, code cleanup and much more
Browse files Browse the repository at this point in the history
this commit is gone bad as it contains too much changes. at first I
tried to do just some code cleanup, but as I jumped from block to block
I just found more and more positions to cleanup. after a few hours of
work it was impossible to follow the changes.

this commit includes:
* massive code cleanup
* in generell more C++-ish code
* use iterator instead of index access where possible
* read, calculate and use 64bit channel ids
* for favourites there's a fallback for old 32bit channel ids
* use channel names from favourites
* replace "/"-character with " " in channel logo urls
* resort methods and member variables in DvbData.h
* resort methods in DvbData.cpp to match the new sorting of DvbData.h
* less LOG_INFO logs, better LOG_DEBUG logs
* use PRId64/PRIu64 for int64_t/uint64_t
* probably much more
  • Loading branch information
manuelm committed Mar 12, 2013
1 parent b7e8ab5 commit 42c1818
Show file tree
Hide file tree
Showing 6 changed files with 1,095 additions and 1,012 deletions.
4 changes: 3 additions & 1 deletion addons/pvr.dvbviewer/addon/changelog.txt
@@ -1,7 +1,9 @@
1.7.6

[added] Basic timeshift support.
[updated] Some code cleanup.
[added] Use channel names from favourites. This allows easy channelname changes.
[fixed] Replace "/"-character by " " in channel logo url
[updated] A lot of code cleanup

1.7.5

Expand Down
Expand Up @@ -54,7 +54,7 @@
<Optimization>Disabled</Optimization>
<RuntimeLibrary>MultiThreadedDebug</RuntimeLibrary>
<AdditionalIncludeDirectories>..\..\..\..\xbmc;..\..\..\..\lib;..\..\..\..\lib\platform\windows</AdditionalIncludeDirectories>
<PreprocessorDefinitions>_WINDLL;TARGET_WINDOWS;_WINSOCKAPI_;_USE_32BIT_TIME_T;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<PreprocessorDefinitions>_WINDLL;TARGET_WINDOWS;_WINSOCKAPI_;_USE_32BIT_TIME_T;_CRT_SECURE_NO_WARNINGS;__STDC_FORMAT_MACROS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
</ClCompile>
<Link>
<GenerateDebugInformation>true</GenerateDebugInformation>
Expand All @@ -71,7 +71,7 @@
<IntrinsicFunctions>true</IntrinsicFunctions>
<RuntimeLibrary>MultiThreaded</RuntimeLibrary>
<AdditionalIncludeDirectories>..\..\..\..\xbmc;..\..\..\..\lib;..\..\..\..\lib\platform\windows</AdditionalIncludeDirectories>
<PreprocessorDefinitions>_WINDLL;TARGET_WINDOWS;_WINSOCKAPI_;_USE_32BIT_TIME_T;_CRT_SECURE_NO_WARNINGS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
<PreprocessorDefinitions>_WINDLL;TARGET_WINDOWS;_WINSOCKAPI_;_USE_32BIT_TIME_T;_CRT_SECURE_NO_WARNINGS;__STDC_FORMAT_MACROS;%(PreprocessorDefinitions)</PreprocessorDefinitions>
</ClCompile>
<Link>
<GenerateDebugInformation>true</GenerateDebugInformation>
Expand Down

0 comments on commit 42c1818

Please sign in to comment.