EndpointQueryCountTest: allow a range for the number of queries on co… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntent_node endpoints With the ResponsiveLayout, we now have mostly ContentNodes which are nested by 2 levels: ColumnLayout -> DefaultLayout -> "Content Nodes with content" This may lead to n+1 db queries that we experienced in the EndpointQueryCountTest. This change now allows to define a range for the query count. This is good enough to keep the performance at the same level.
This was referenced Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ntent_node endpoints
With the ResponsiveLayout, we now have mostly ContentNodes which are nested by 2 levels: ColumnLayout -> DefaultLayout -> "Content Nodes with content" This may lead to n+1 db queries that we experienced in the EndpointQueryCountTest. This change now allows to define a range for the query count. This is good enough to keep the performance at the same level.
@manuelmeister
You can either merge this PR, or #4