Correctly handle remove from array

manuelstofer · Oct 9, 2016 · ae22861 · ae22861
1 parent 1189b27
commit ae22861
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -104,7 +104,18 @@ api.remove = function (obj, pointer) {
     if (finalToken === undefined) {
         throw new Error('Invalid JSON pointer for remove: "' + pointer + '"');
     }
-    delete api.get(obj, refTokens.slice(0, -1))[finalToken];
+
+    var parent = api.get(obj, refTokens.slice(0, -1));
+    if (Array.isArray(parent)) {
+      var index = +finalToken;
+      if (finalToken === '' && isNaN(index)) {
+        throw new Error('Invalid array index: "' + finalToken + '"');
+      }
+
+      Array.prototype.splice.call(parent, index, 1);
+    } else {
+      delete parent[finalToken];
+    }
 };
 
 /**