Fix missleading error-messages

This commit finally fixes #7! Additionally opening files now also is supported for macOS and Linux-OSes.
manuth · May 22, 2017 · 7cd4e20 · 7cd4e20
1 parent c7ca0eb
commit 7cd4e20
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,9 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
 
 ## 0.0.8
   - Reworked the PhantomJS-process [#1](https://github.com/manuth/MarkdownConverter/issues/1)
+  - Adjusted the way to handle templates [#6](https://github.com/manuth/MarkdownConverter/issues/6)
+  - Provided the functionallity to choose whether to embed or link certain css-files [#4](https://github.com/manuth/MarkdownConverter/issues/4)
+  - Patched missleading error-messages [#7](https://github.com/manuth/MarkdownConverter/issues/7)
 
 <!--- References -->
 [MarkdownItCheckbox]: https://www.npmjs.com/package/markdown-it-checkbox
diff --git a/src/Program.ts b/src/Program.ts
@@ -56,7 +56,31 @@ export class Program
                 {
                     if (label == localize(1 /* "OpenFileLabel" */, null))
                     {
-                        ChildProcess.exec(Format('"{0}"', destination));
+                        try
+                        {
+                            /**
+                             * Opening a file...
+                             * ...the windows-way...
+                             */
+                            ChildProcess.execSync(Format('"{0}"', destination));
+                        }
+                        catch (e)
+                        {
+                            try
+                            {
+                                /**
+                                 * ...the linux-way...
+                                 */
+                                ChildProcess.execSync(Format('bash -c \'xdg-open "{0}"\'', destination))
+                            }
+                            catch (e)
+                            {
+                                /**
+                                 * ...and the macOS-way
+                                 */
+                                ChildProcess.execSync(Format('bash -c \'open "{0}"\'', destination))
+                            }
+                        }
                     }
                 });
             }

diff --git a/src/extension.ts b/src/extension.ts
@@ -41,7 +41,7 @@ export function activate(context: vscode.ExtensionContext)
         }
         catch (e)
         {
-            vscode.window.showErrorMessage(localize(6 /* PhantomRebuildException */, null));
+            vscode.window.showErrorMessage(localize(7 /* PhantomRebuildException */, null));
             phantomJSBuilt = false;
         }
     }
@@ -60,7 +60,7 @@ export function activate(context: vscode.ExtensionContext)
             }
             else
             {
-                vscode.window.showWarningMessage(localize(6 /* PhantomRebuildException */, null));
+                vscode.window.showWarningMessage(localize(7 /* PhantomRebuildException */, null));
             }
         }
         else