Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wants to download chromium #74

Closed
tik9 opened this issue May 15, 2021 · 5 comments · Fixed by #86
Closed

wants to download chromium #74

tik9 opened this issue May 15, 2021 · 5 comments · Fixed by #86
Assignees

Comments

@tik9
Copy link

tik9 commented May 15, 2021

When I want to run your extension, it asks me to download chromium. But it is already installed. Can I point your extension to my chromium in /usr/bin/chromium?

@manuth
Copy link
Owner

manuth commented May 15, 2021

Thanks for pointing this out!
As far as I remember, there is no such option but I'll make sure to have this implemented for the next version

Thanks for using MarkdownConverter 💫

@orgwem
Copy link

orgwem commented Jun 30, 2021

Would really love to see a way to specify already installed Chrome oder Chromium. I am behind a corporate firewall which disallows downloading Chromium. However, Chrome is already installed on my machine so I could use that instead.

@manuth
Copy link
Owner

manuth commented Jun 30, 2021

That's a good input - iirc, puppeteer actually does allow you to specify a custom chromium path, so I should be able to implement this easily!

I'm starting to work on MarkdownConverter again once I caught up with all my other projects

@orgwem
Copy link

orgwem commented Jul 1, 2021

And that's good news! Currently I have to use the plugin "markdown-pdf" by yzane (https://github.com/yzane/vscode-markdown-pdf) as it allows for that exact feature via the setting "markdown-pdf.executablePath". However this plugin is meant for american users (e.g. date format Month/Day/Year) and I would prefer having more output control.

@manuth manuth self-assigned this Sep 12, 2021
@manuth manuth added this to the Major Release December 2020 milestone Sep 12, 2021
@manuth
Copy link
Owner

manuth commented Sep 12, 2021

I'm planning to allow users to specify their own ChromiumExecutablePath (let me know if you guys can make up a better setting-name) in their settings.
This will disable MarkdownConverters question on whether to download the puppeteer-cores Chrome-revision and will instead check whether a file exists at the location indicated by the ChromiumExecutablePath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment