Don't simultaneously test -c and -v switches #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up through perl-5.37.3, there was a bug in perl (see Perl/perl5#20252 (comment)) which permitted simultaneous use of the '-c' and '-v' switches to the perl interpreter. Once this bug was corrected, t/01all.t began to fail. As Test::Strict has many CPAN distributions depending on it, this test failure has had wide impact. This pull request modifies tests appropriately and has been tested on bleadperl (v5.37.7-134-g25948dfb24) and on perl-5.32.1, in both cases on threaded builds on FreeBSD-12. Devel::Cover was not installed on bleadperl, hence t/04cover.t was skipped on that build. Otherwise, all tests are passing. In the course of testing, certain additions were made to .gitignore and MANIFEST.SKIP to get metadata-oriented tests to pass. NOTE: In my git checkout I find the following file: .git/hooksfsmonitor-watchman.sample This is deemed by 'file' to be a Perl executable. As such, it is pushed onto the list of files tested by 'all_perl_files_ok()' at the start of t/01all.t. This in turn means that in my 'git checkout' the count of tests is off by 2 and the test is reported to fail. "Looks like you planned 59 tests but ran 61." Because the files in .git/hooks/ should not be included in the tarball, the count of tests is correct when run from the tarball. I leave to the maintainer to determine how to square this circle. You should probably check for the presence of a .git/ directory and exclude that directory from the list of directories passed to all_perl_files_ok(). For manwar#32
|
Yeah, this looks right to me. Passes tests as well, except for the issue you mentioned about "Looks like you planned 59 tests but ran 61." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up through perl-5.37.3, there was a bug in perl (see Perl/perl5#20252 (comment)) which permitted simultaneous use of the '-c' and '-v' switches to the perl interpreter. Once this bug was corrected, t/01all.t began to fail. As Test::Strict has many CPAN distributions depending on it, this test failure has had wide impact.
This pull request modifies tests appropriately and has been tested on bleadperl (v5.37.7-134-g25948dfb24) and on perl-5.32.1, in both cases on threaded builds on FreeBSD-12. Devel::Cover was not installed on bleadperl, hence t/04cover.t was skipped on that build. Otherwise, all tests are passing. In the course of testing, certain additions were made to .gitignore and MANIFEST.SKIP to get metadata-oriented tests to pass.
NOTE: In my git checkout I find the following file:
This is deemed by 'file' to be a Perl executable. As such, it is pushed onto the list of files tested by 'all_perl_files_ok()' at the start of t/01all.t. This in turn means that in my 'git checkout' the count of tests is off by 2 and the test is reported to fail.
Because the files in .git/hooks/ should not be included in the tarball, the count of tests is correct when run from the tarball. I leave to the maintainer to determine how to square this circle. You should probably check for the presence of a .git/ directory and exclude that directory from the list of directories passed to all_perl_files_ok().
For #32