Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Action #49

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Added GitHub Action #49

merged 2 commits into from
Oct 30, 2020

Conversation

MarcelCoding
Copy link
Contributor

Added a GitHub action which sorts the password.csv and updates the count of passwords in the README.md file.

@piechowiakmichal
Copy link
Member

Hello, interesting script. It will definitely be useful (especially when there will be several thousand entries to be sorted). Thank you for your contribution!

@piechowiakmichal piechowiakmichal merged commit 70e4f66 into many-passwords:main Oct 30, 2020
@piechowiakmichal
Copy link
Member

Hi, I use the github action you wrote and it sorts passwords in passwords.csv, but it doesn't update the number of passwords in README.md. From what I can see, it should be doing it. Am I doing something wrong that it does not work?

@MarcelCoding
Copy link
Contributor Author

Yesterday it worked. I looked into your readme file, but I can't find any changes. Did you change anything?

@piechowiakmichal
Copy link
Member

I didn't change anything, and I updated the readme password count manually (because github action wouldn't work).

@MarcelCoding
Copy link
Contributor Author

I found the problem: You changes the count of the code block symbols. Diff If you change the count to tow symbols it should work, i tested it local.

@piechowiakmichal
Copy link
Member

I have uploaded a README from your repository but it still doesn't work. What are tow symbols?

@piechowiakmichal
Copy link
Member

I understand the mistake. Thank you very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants