feat(igp): handle zero gas #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-savu
approved these changes
Oct 28, 2023
contracts/igps/core/src/query.rs
Outdated
Comment on lines
73
to
74
| Ok(QuoteDispatchResponse { | ||
| gas_amount: Some(coin( | ||
| quote_res?.gas_needed.to_string().parse::<u128>()?, | ||
| GAS_TOKEN.load(deps.storage)?, | ||
| )), | ||
| gas_amount: if gas_needed.is_zero() { |
There was a problem hiding this comment.
nit: I'd assign to a variable on a line above to keep this easy to read, like
let gas_amount = if gas_needed.is_zero() {
None
} else {
Some(coin(
gas_needed.to_string().parse::<u128>()?,
GAS_TOKEN.load(deps.storage)?,
))
};
Ok(QuoteDispatchResponse {
gas_amount
})
There was a problem hiding this comment.
It makes sense
byeongsu-hong
added a commit
that referenced
this pull request
Nov 1, 2023
* some scripts (#50) * feat: deploy scripts * refactor * filter wasm event * feat: utilties --------- Co-authored-by: hashableric <hashableric@gmail.com> * fix: coverage ci (#49) * try: use llvm cov * fix * asdf * nightly * test: warp route (#51) * Revert "revert: aggregate" This reverts commit 00fe615. * test(cw20): cw20 init * test(warp): unit test for cw20 * test(warp): add query test for cw20 * test(warp): remove existing tests for native * feat(warp): add ownable message * wip * test(warp): unit test for native denom * test: use u32 directly * fix!(ism): use parsed u32 merkle index * test: modularize * test: add empty warp * test: runnable mailbox * test: warp placeholder * test: deployable * fix(warp): inject minter to cw20 * fix(warp): use consistant event name * test: warp cw20 / native denom creation * chore: prune * feat: aggregation * schema * fix: evm equivalence * fix(hook): pass entire metadata * fix: aggregate works * chore: remove debugger * fix: tests * clippy * use aggregate ism on integration test * feat: migrate to aggregations (#53) * with proper igp and aggregation * rc4 * fix: use ethereum-style address scheme (#55) * set mailbox version to 3 * feat(ism): use ethereum-style address to verify * feat: add enroll / unenroll test * refactor: merge into one file * make test runnable * test: add case * fix: with all (#54) * fix: with all * broken test --------- Co-authored-by: byeongsu-hong <hong@byeongsu.dev> * feat: mailbox as binary * rc5 * feat: use recovery param from signature * fix: va test --------- Co-authored-by: Eric <125242347+hashableric@users.noreply.github.com> Co-authored-by: hashableric <hashableric@gmail.com> * feat: use eth_addr * feat: open testnet deployment * fix(warp): consideration of igp (#56) * fix: merkle tree * fix(warp): gas issue * fix(warp): use transfer from * feat(warp): enable migration * clippy * feat: scripts * feat(hook): enable migrate * build: new code * chore: addr converter * fix: inherit ism * build: migrate * feat: inheritable ism receiver interface * fix: hide important files * rc6 * feat: migratable * migrate * fix: remove feature & deploy codes * feat(warp): make ism configurable * feat(warp): make hook configurable * feat(warp): apply hook * feat: connection client (#58) * feat: make gas amount none if is zero * Revert "feat: make gas amount none if is zero" This reverts commit bac3aa2. * feat(igp): handle zero gas (#59) * feat: make gas amount none if is zero * clean code * feat: uploading codes to each networks (#60) * new codes for devnet - dev * new codes for mainnet - dev * new codes for devnet / mainnet - prod * fix: assert addr len (#61) * fix: assert addr len * new codes for devnet / mainnet - prod * fix test * Deployment scripts (#62) * Deployment scripts * chore: use dash case (#63) * chore: use dash case * fix: make inject works --------- Co-authored-by: ByeongSu Hong <hong@byeongsu.dev> * feat(igp): default gas works (#64) * feat(igp): default gas works * fix test * test(igp): gas config * feat: new codes * feat: add migration * revert: roll back igp-oracle migration * chore: with migration * feat: conv rev * migrate * feat: add default gas * feat(igp): add gas query * feat: store igp --------- Co-authored-by: hashableric <hashableric@gmail.com> Co-authored-by: Eric <125242347+hashableric@users.noreply.github.com> Co-authored-by: Nam Chu Hoai <nambrot@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.