Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read .ruby-version into Gemfile #1838

Merged
merged 2 commits into from Mar 18, 2024
Merged

Read .ruby-version into Gemfile #1838

merged 2 commits into from Mar 18, 2024

Conversation

Floppy
Copy link
Collaborator

@Floppy Floppy commented Feb 7, 2024

With gem version >= 3.4.19, we can read the ruby version straight from a file. Let's try it!

@Floppy Floppy added the feature User-facing features and product enhancements label Feb 7, 2024
@Floppy Floppy marked this pull request as draft February 7, 2024 19:41
@Floppy
Copy link
Collaborator Author

Floppy commented Feb 7, 2024

Meh, looks like it's not pulling a high enough gem version by default, yet.

@Floppy Floppy marked this pull request as ready for review March 18, 2024 12:26
@Floppy Floppy marked this pull request as draft March 18, 2024 12:27
Copy link

codeclimate bot commented Mar 18, 2024

Code Climate has analyzed commit 2eab25a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.1% (0.0% change).

View more on Code Climate.

@Floppy Floppy marked this pull request as ready for review March 18, 2024 13:32
@Floppy Floppy merged commit fed1be9 into main Mar 18, 2024
8 of 9 checks passed
@Floppy Floppy deleted the ruby-version-in-gemfile branch March 18, 2024 13:32
@Floppy Floppy added improvement Refactors and behind-the-scenes improvements and removed feature User-facing features and product enhancements labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Refactors and behind-the-scenes improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant