Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix separate database env vars #2116

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Fix separate database env vars #2116

merged 1 commit into from
Apr 27, 2024

Conversation

aneurinprice
Copy link
Contributor

@aneurinprice aneurinprice commented Apr 26, 2024

Add an export so that this actually works. - Tested and working.

Checklist

馃毃 Please review the guidelines for contributing to this repository. 馃毃

  • Make sure you are making a pull request against our main branch (left side)
  • Check that that your branch is up to date with our main.
  • [] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • [] Check that the tests and code linter both pass.
  • If you're a new contributor, please sign our contributor license agreement.

Warnings

  • This PR will change existing database contents.
  • This PR introduces a breaking change to existing installations.

Summary

This change will actually fix my previous commit that allowed for specifying the database in a more granular way. The code in main right now silently fails onto the sqlite database.

Description of changes

added an export onto the variable for database url

Add an export so that this actually works.
Copy link

codeclimate bot commented Apr 26, 2024

Code Climate has analyzed commit 7ece6cd and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 87.1% (0.0% change).

View more on Code Climate.

@Floppy Floppy changed the title Update docker-entrypoint.sh Fix separate database env vars Apr 27, 2024
@Floppy Floppy merged commit 49f5a0c into manyfold3d:main Apr 27, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants