Fix accessibility issues on image carousel #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and disable pause-on-focus behaviour until we can work out how to differentiate keyboard and mouse focus
Floppy
added
bug
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
|
|
||
| function onPause (pause: boolean, updateState: boolean): void { | ||
| if (pause) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| $('#rotationControlIcon').addClass('bi-play') | ||
| $('#rotationControlIcon').removeClass('bi-pause') | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 0a9029d and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 87.1% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2106
This was a biggie. Making a fully a11y compliant carousel is trifficult! The only thing missing is that it should auto-pause when it gets keyboard focus, but I can't work out how to do that because focus events look identical from mouse or keyboard, and triggering it too much causes problems. So, better to leave that feature out and call it close enough.