Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rubocop to lint Rails and RSpec usage #866

Merged
merged 21 commits into from
Dec 12, 2022
Merged

Add rubocop to lint Rails and RSpec usage #866

merged 21 commits into from
Dec 12, 2022

Commits on Dec 12, 2022

  1. run rubocop configured for standard, rather than standardrb

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    09c5ca8 View commit details
    Browse the repository at this point in the history

  2. autofix in precommit hook

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    aaaa6fb View commit details
    Browse the repository at this point in the history

  3. add rubocop-rails and rubocop-rspec

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    db0a95d View commit details
    Browse the repository at this point in the history

  4. lint: don't use find_by_x

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    a3c32e1 View commit details
    Browse the repository at this point in the history

  5. lint: time methods

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    bdc7ecc View commit details
    Browse the repository at this point in the history

  6. lint: prefer Rails.root.join

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    2efde55 View commit details
    Browse the repository at this point in the history

  7. reorder controller methods

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    24b2e27 View commit details
    Browse the repository at this point in the history

  8. lint: fix non-reversible migration

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    8d43df1 View commit details
    Browse the repository at this point in the history

  9. lint: use Rails.root.join with single string

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    2a2daf6 View commit details
    Browse the repository at this point in the history

  10. add rubocop TODO for some more awkward fixes so we can do them later

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    c5a4901 View commit details
    Browse the repository at this point in the history

  11. lint: brackets in factorybot

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    e1701e5 View commit details
    Browse the repository at this point in the history

  12. lint: use be instead of eq

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    dce7005 View commit details
    Browse the repository at this point in the history

  13. lint: remove :each in befores

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    2ce0318 View commit details
    Browse the repository at this point in the history

  14. lint: use create list instead of x.times

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    b4a1fdf View commit details
    Browse the repository at this point in the history

  15. lint: remove redundant test types

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    c308a45 View commit details
    Browse the repository at this point in the history

  16. lint: use described_class

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    9a4f849 View commit details
    Browse the repository at this point in the history

  17. lint: remove FactoryBot. prefix

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    b99cd4f View commit details
    Browse the repository at this point in the history

  18. remove duff spec

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    4d0d140 View commit details
    Browse the repository at this point in the history

  19. Add rspec linting TODO

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    b92f0b5 View commit details
    Browse the repository at this point in the history

  20. ignore vendor/bundle when linting

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    c945c55 View commit details
    Browse the repository at this point in the history

  21. add all default rubocop exclusions

    @Floppy
    Floppy committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    a0febf5 View commit details
    Browse the repository at this point in the history