Skip to content
This repository has been archived by the owner on Jan 1, 2024. It is now read-only.

Question: hide body and subject in modal #90

Closed
yoavaviram opened this issue Oct 21, 2020 · 14 comments
Closed

Question: hide body and subject in modal #90

yoavaviram opened this issue Oct 21, 2020 · 14 comments
Labels
enhancement New feature or request

Comments

@yoavaviram
Copy link

Hi Matteo,

Thanks for the direct render functionality. I just tested it and it works as I had hoped!

I've got one unrelated question. What would be the best way to hide the subject and body in the modal? In my case they are both quite lengthy and therefore it does not make sense to display them.

Thanks,

Yoav

@manzinello
Copy link
Owner

Interesting suggestion. Maybe I can work on new attributes in MailgoConfig for this!

@manzinello manzinello added the enhancement New feature or request label Oct 21, 2020
@yoavaviram
Copy link
Author

That would be awesome!

@yoavaviram
Copy link
Author

Hi @manzinello , have you made any progress on this one?

@manzinello
Copy link
Owner

Hi @yoavaviram, at the moment I am testing a new version of mailgo (0.11.0), that contains already a lot of changes.
After the release i will work on enhancements like this one, absolutely.

@manzinello
Copy link
Owner

I've worked on this! There will be the new details attribute in configuration where you will be able to show/hide elements of the details from the modal (cc, bcc, body and subject for emails, msg for tel).
I am working on this (and testing it), you can check it in index.windowconfig.html in examples removing the comment on cc (2bce02b)

@yoavaviram
Copy link
Author

Amazing, when do you think it will be released?

@manzinello
Copy link
Owner

I will try to release a new mailgo version with these new features within the end of the week!
I will keep you updated about this directly in this issue.

@yoavaviram
Copy link
Author

Thanks!

@manzinello
Copy link
Owner

Relased mailgo 0.11.2 now with the new details attribute in configuration, here the documentation: https://mailgo.dev/docs/configuration#details.
I close this issue, if there is something else please open a new one!

@yoavaviram
Copy link
Author

yoavaviram commented Dec 4, 2020

Amazing!

We're now using mailgo in production (for example when you submit the form at the top of this page. I've also added you to our list of sponsors on our about page.

A few questions and comments:

  1. It seems like the direct render option parses configuration in a different way to the normal initialization. While the 'details' attribute is supported 'dark' is not.
  2. Maybe related to number 1, passing a dictionary with configuration options to the direct renderer had no affect. I had to use window.mailgoConfig option. If this is the intended usage I suggest noting it in the documentation since it was not obvious to me.
  3. It would be great to be able to hide the 'to' field in addition to the others (subject, bcc, cc, body). In my use the user is about to review all of these fields in their email client so no reason to do it twice.

Here is the code that's currently in production: https://github.com/your-digital-rights/yourdigitalrights.org/blob/master/src/components/PersonalInfoForm/index.js

Many thanks!

@manzinello
Copy link
Owner

Thank you so much for your comments! I will check it and maybe will open single issues for them. In particular the first 2 seems to be bugs, so I have obviously to check them in deep. If you want to open single issues for them feel free to to it, otherwise I will do it.
Have a great day,

@yoavaviram
Copy link
Author

Another issue: clicking on 'copy' only copies the recipient's email address.

@yoavaviram
Copy link
Author

Also, the subject line opens up as the "to" address in gmail. This makes the librafry unusable for us in the current state.

@yoavaviram
Copy link
Author

I have opened issues for the relevant problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants