Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revitalize CI #96

Merged
merged 6 commits into from Jun 25, 2023
Merged

Revitalize CI #96

merged 6 commits into from Jun 25, 2023

Conversation

alaendle
Copy link
Contributor

Some remarks:

  • Regenerated and manually adapted the workflow yaml haskell-ci.yml(to include influxdb service & allow localhost access from another container). No further changes - so another regeneration should be easy.
  • Removed all warnings from cabal check - changes in influxdb.cabal
  • Added cabal.haskell.ci to only build documentation (haddock) on newer GHC's (because older haddock versions don't parse newer code)
  • Fixed the doctest I have introduced to be more v2 compatible (changes in JSON.hs)
  • Avoid -XOverloadedLists - this gives very strange results with ghc 9.4.5 - so changed UDP.hs (to mimic Write.hs)
  • Adopted regressions.hs to accept parser failure from different aeson versions.

So I think the change-set is relatively straightforward - and I hope ready to merge.

Before a new release is made we should maybe consider supporting ghc 9.6 (in a new PR)?

@maoe
Copy link
Owner

maoe commented Jun 25, 2023

Thanks! I'll take a look tonight.

@alaendle
Copy link
Contributor Author

@maoe - I also have ghc-9.6-support in place, but I thought two different PR's might be better, so I started this one first 😉 So if you take a look at it later maybe you also want to merge https://github.com/alaendle/influxdb-haskell/tree/feature/ghc-9.6.

Copy link
Owner

@maoe maoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

INFLUXDB_VERSION: 1.8.4
services:
influxdb:
image: influxdb:1.8.10
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know it's available like this. Nice!

@maoe maoe merged commit 0c4a5f0 into maoe:develop Jun 25, 2023
7 checks passed
@maoe
Copy link
Owner

maoe commented Jun 25, 2023

@maoe - I also have ghc-9.6-support in place, but I thought two different PR's might be better, so I started this one first 😉 So if you take a look at it later maybe you also want to merge https://github.com/alaendle/influxdb-haskell/tree/feature/ghc-9.6.

Sorry I missed this comment. Could you please send a PR for that?

@alaendle
Copy link
Contributor Author

Sure, here is the PR for ghc 9.6 #97.

maoe added a commit that referenced this pull request Jun 29, 2023
v1.9.3

* Mitigate InfluxDB compatibility problems (#94)
* Support GHC 9.4 and 9.6 (#95 and #97)
* Revitalize CI (#96)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants