In .Safe module, use async's concurrently, race, and race_ #20
Conversation
The upstream versions of the functions are more efficient, being implemented via MVars and not leveraging the full Async machinery. In addition to getting a performance boost from this change, we also guarantee that, in the case of deadlocks, the exceptions generated from the .Safe module match those generated by Control.Concurrent.Async. Note that this change does not make sense for the unsafe module in this package.
|
Forgot to ping @feuerbach |
|
|
||
| -- | Helper function which converts an 'IO'-specialized combinator | ||
| -- into a generalized combinator. | ||
| unliftFuncs :: forall m a b c. (MonadBaseControl IO m, Forall (Pure m)) |
There was a problem hiding this comment.
Could we rename unliftFuncs to liftBaseOp2_? It's more like liftBaseOp_ in monad-control but the argument function takes two params and also it has Forall (Pure m) constraint.
|
Made the fixes and some other optimizations: https://github.com/maoe/lifted-async/tree/snoyberg/develop |
|
Very nice! On Sun, May 22, 2016 at 5:44 AM, Mitsutoshi Aoe notifications@github.com
|
|
Thanks for the contribution! I merged this commit into develop. GitHub doesn't seem to think this PR has been merged for some reason, so I'm closing this manually. I'll release a new version on Hackage shortly. |
The upstream versions of the functions are more efficient, being
implemented via MVars and not leveraging the full Async machinery. In
addition to getting a performance boost from this change, we also
guarantee that, in the case of deadlocks, the exceptions generated from
the .Safe module match those generated by Control.Concurrent.Async.
Note that this change does not make sense for the unsafe module in this
package.