Simplest support of Windows with Docker #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combination of docker and MSYS2 doesn't seem to convert Windows path properly Converting the path explicitly with cygpath worked Tried with Docker version 17.04.0-ce, build 4845c56
|
Thanks for your contribution! Could you extend the README to show how to use it? |
maoe
requested changes
May 7, 2017
README.md
Outdated
| $ cd viewprof/docker | ||
| $ docker-machine start | ||
| $ docker build -t viewprof . | ||
| $ .\viewprof.bat path/to/file.prof |
There was a problem hiding this comment.
Does Windows accept forward slash delimiters?
There was a problem hiding this comment.
Yes, actually whichever will do.
README.md
Outdated
|
|
||
| #### How to install and launch | ||
|
|
||
| ```bash |
There was a problem hiding this comment.
Should we use bat or something instead? Or is it actually bash?
README.md
Outdated
| #### How to install and launch | ||
|
|
||
| ```bash | ||
| $ git clone git@github.com:maoe/viewprof.git |
There was a problem hiding this comment.
Please drop the $-signs to make the instructions copy-paste friendly.
README.md
Outdated
| @@ -17,12 +17,31 @@ It has three display modes: | |||
|
|
|||
| ## Installation | |||
|
|
|||
| Note: Currently viewprof doesn't support Windows because the underlying library (vty) doesn't support it yet. See [#1](https://github.com/maoe/viewprof/issues/1). | |||
| For Windows users, see below. | |||
There was a problem hiding this comment.
Let's drop this sentence. The following instruction is short.
|
Squashed last three commits and merged into feature/docker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #1
But there're still problems:
cygpath(tool to convert Windows path into the POSIX one)Tried with: Docker Toolbox v17.04.0ce