Fix subtitle margin

[sajadspeed]

Set margin from the bottom when OSC is visible.

[zydezu]

It may be better to adjust subtitle positioning based on the resolution of the window, else subtitles are obstructed.

function adjustSubtitles()
    if user_opts.raisesubswithosc and state.osc_visible == true and (state.fullscreen == false or user_opts.showfullscreen) then
        local w, h = mp.get_osd_size()
        if h > 0 then
            mp.commandv('set', 'sub-pos', math.floor((osc_param.playresy - 175)/osc_param.playresy*100)) -- percentage
        end
	else
		mp.commandv('set', 'sub-pos', 100)
	end	
end

This is my solution to this.

[sajadspeed]

I didn't exactly understand your code, but I replaced the function you wrote with my own function, but it didn't work. Did I make a mistake somewhere?

[zydezu]

Ah I'm sorry! I may have changed the subroutine name in my code from subtitle_fix() to adjustSubtitles(), try that!

I didn't exactly understand your code, but I replaced the function you wrote with my own function, but it didn't work. Did I make a mistake somewhere?

[sajadspeed]

I noticed this. I replaced the code inside the function you wrote with my own code and it didn't work.

[zydezu]

Oh im sorry ... it's the user_opts.raisesubswithosc ... remove that (and the and) and maybe it'll work? Sorry my own fork is slightly different in the implementation.

[sajadspeed]

Oh im sorry ... it's the user_opts.raisesubswithosc ... remove that (and the and) and maybe it'll work? Sorry my own fork is slightly different in the implementation.

No, that didn't work either.