Added flag to skip file errors during copy #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lhgloj1 <jannic.lollert@liebherr.com>
|
thanks for contributing! i believe you will need to update |
|
Yes I will do so |
|
@sunoce I think in the meantime maorfr/skbn#23 was merged. Could you complete this PR? I'm really missing this feature you implemented 👍 |
|
@maorfr I am running into this issue also. |
|
@sdave2 this project seems to be unmaintained. I forked it and fixed it myself in the meantime here: https://github.com/amerello/kube-tasks. My fork is working for me at least, you may have a try :) Edit: I forked because the nuvo fork is incomplete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So in case an error occurs for one file, the file is skipped. The behavior is triggered via the method parameter skipErrorFiles.
If the parameter is set to false the behaviour is the same as before.
I have never coded go but this fix allowed me to skip files that got deleted during the backup run.
If there are better ways feel free to adjust or comment.
NOTE:
This PR can only be merged after this PR got merged: maorfr/skbn#23
Signed-off-by: lhgloj1 jannic.lollert@liebherr.com