Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add caching. #14

Open
maormagori opened this issue Apr 12, 2023 · 0 comments
Open

feat: Add caching. #14

maormagori opened this issue Apr 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@maormagori
Copy link
Owner

Although I do believe we have built-in caching when it comes to SRT files as they are considered by Beamup as static content, we still got to make sure of that.

Subtitles list requests are not cached because their route has the query param which prevents the requests from being identical and so makes route-based-caching useless. For example:
/subtitles/movie/tt9407490/videoHash=fe4032afd8b70beb&videoSize=1567260672&filename=Freies.Land.2019.D.BDRip.1.46Gb.MegaPeer.avi.json
/subtitles/movie/tt9407490/videoHash=fe40328b70beb&videoSize=1567260672&filename=Freies.Land.2019.DVDRIP.MegaPeer.avi.json

These two routes should return the same subtitles array just sorted differently.
@maormagori maormagori added the enhancement New feature or request label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maormagori