added some submenu to select time by hours, minutes, seconds #57
Conversation
|
ah.... Glade... i don't understand what changed by reading the diffs, could you post a screenshot please? |
|
Should look like this: |
|
Ok i see. Could you please:
Only do this first part, because for the following idea, i'm not sure how it'll look so i want to try various designs As you said, the feature makes sense if and only if the wallpaper is designed to fit 24 hours. But in this case, the values to fill these spinbuttons are already computed somewhere to be shown in labels, whose visibility is already linked to whether or not it's a 24h-wallpaper So once your popover is more reusable, the fix would "just" be to change the labels highlighted here
into menubuttons (for both the times where it's static and the times of the transition), where the relief is none, the popover is your file, and the label is the same as the current label. (And then connect the spin-buttons to some methods, but i'll see this even later) |
|
Sure, but won't be able to do this until tomorrow evening 🤔 |
|
Don't worry, take as much time as you want |
|
Do you want me to just move the code to a new file or shall it be connected with the rest of the code? |
…n class for this popup Buttons in this class are connected to empty signals which can become connected to some other function. The class takes a parent widget as attribute; which could be updated … The class also takes the start and end times as hours, minutes and seconds; the spin buttons are initialized with these values.
|
Ok, I implemented some new class for the popover and created a new ui file as well as I reverted the old ui to the master state. |
|
perfect, i'll try to connect it to the rest, maybe this week |
Please notice that this will only allow to set the interval in hours, minutes and seconds; because using the spin button is painfully slow and ineffective. This might be changed in the future to control at which time of the day the image is going to be displayed …
However, in this current implementation it does only change the value of the current spin button and nothing more.
Controlling the start time would require to change the UI in the case that the fit day option is enabled - at least in my opinion.
issue #55