Enhanced custom weapons support #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samisalreadytaken
pushed a commit
to samisalreadytaken/source-sdk-2013
that referenced
this pull request
Jan 15, 2023
Kick code falls back to entity parents Approved-by: 1upD
Blixibon
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
This looks good to me.
Obviously, I'm extremely late on this, and I'd like to apologize for not getting to this PR sooner. The changes in this were substantial enough that I put it off for a future update instead of v7.0 or v7.1, and it unfortunately took me a long time before I was able to begin work on that.
This seems like an amazing system and it fills an important niche in Mapbase's capabilities. Custom weapons are commonly sought after in mapping competitions, and while overriding existing weapons and using the experimental VScript-driven custom weapon were more-or-less passable methods, this takes things to another level. I hope that people can make good use of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New custom weapons system with support for script-defined entity classnames.
Test Content
Does this PR close any issues?
PR Checklist
developbranch OR targets another branch with a specific goal in mind