Internalize mapbender versioning into mapbender repository #1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branding, the everlasting joy of life.
This provides Mapbender-internal Mapbender versioning and naming, while still supporting explicit project branding overides.
A new compiler pass displaces fom: server_version et al as the authoritive source of the Mapbender version. Mapbender gains version knowledge inside itself.
Any
server_version
orserver_name
values configured in FOM that follow certain well-treaded patterns are dropped on the floor and replaced by Mapbender's own. If they deviate significantly from historic default values used in vanilla Github versions of Mapbender Starter, we treat them as desired project-specific overrides and leave them alone.We also add new parameter keys for direct project-specific overrides of name, version and logo. These will always win out, even if they happen to say "Mapbender3" "v3.0pre2" (which would be ignored if it appeared under fom : server_*).
Motivation: currently, git tags are the only hard source of Mapbender versioning information inside the actual Mapbender repository.
fom
:server_*
is defined in another repository. This mandates parallel updates of multiple repositores at every versioning cycle and throws a wrench into introspection.This pull obsoletes Mapbender version information in Mapbender Starter.