Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalize mapbender versioning into mapbender repository #1012

Merged
merged 4 commits into from Sep 24, 2018

Conversation

werrolf
Copy link
Contributor

@werrolf werrolf commented Aug 29, 2018

Branding, the everlasting joy of life.

This provides Mapbender-internal Mapbender versioning and naming, while still supporting explicit project branding overides.

A new compiler pass displaces fom: server_version et al as the authoritive source of the Mapbender version. Mapbender gains version knowledge inside itself.

Any server_version or server_name values configured in FOM that follow certain well-treaded patterns are dropped on the floor and replaced by Mapbender's own. If they deviate significantly from historic default values used in vanilla Github versions of Mapbender Starter, we treat them as desired project-specific overrides and leave them alone.

We also add new parameter keys for direct project-specific overrides of name, version and logo. These will always win out, even if they happen to say "Mapbender3" "v3.0pre2" (which would be ignored if it appeared under fom : server_*).

Motivation: currently, git tags are the only hard source of Mapbender versioning information inside the actual Mapbender repository. fom: server_* is defined in another repository. This mandates parallel updates of multiple repositores at every versioning cycle and throws a wrench into introspection.

This pull obsoletes Mapbender version information in Mapbender Starter.

@werrolf
Copy link
Contributor Author

werrolf commented Aug 29, 2018

We now also get a console command mapbender:version. This is intended mainly to feed into outside scripts that require a version for packaging or other tasks, such as ComposerBootstrap::genApiDocumentation.

With the following in my parameters.yml:

parameters:

    branding.project_name: Awesomebender
    branding.project_version: 9000

I receive the following output:

application$ app/console mapbender:version
Mapbender 3.0.7.4
application$ app/console mapbender:version --project
Awesomebender 9000

Likewise, my backend now displays v. 9000 top-right, and my unmodified AboutDialog welcomes me to Awesomebender Version 9000.

@werrolf werrolf added this to the 3.0.7.5 milestone Sep 12, 2018
@werrolf werrolf merged commit 42e0f8b into release/3.0.7 Sep 24, 2018
@werrolf werrolf deleted the fix/mapbender-branding-handled-by-mapbender branch September 24, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants