Fix MapbenderContainerInfo-using widget behaviours in button-style sidepanes #1097
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapbenderContainerInfo was devised as a way to help Elements living in sidepanes reacting to the user switching accordion tabs. Unfortunately, only accordion tabs. Plus a bunch of getters for properties of the container.
This change ties a knot between MapbenderContainerInfo and the recent attempt at more uniform sidepane element control. MCI instances are punched into the element node data if present, and provisions are made to invoke those callbacks, even though MCI itself no longer does any of this itself.
The immediate benefit is that Element widgets relying on MapbenderContainerInfo now behave properly in a
buttons
-style sidepane. Most prominently, Digitizer now correctly switches itself on and off. This was previously only possible in anaccordion
-style sidepane.