Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MapbenderContainerInfo-using widget behaviours in button-style sidepanes #1097

Merged
merged 1 commit into from Feb 15, 2019

Conversation

werrolf
Copy link
Contributor

@werrolf werrolf commented Feb 15, 2019

MapbenderContainerInfo was devised as a way to help Elements living in sidepanes reacting to the user switching accordion tabs. Unfortunately, only accordion tabs. Plus a bunch of getters for properties of the container.

This change ties a knot between MapbenderContainerInfo and the recent attempt at more uniform sidepane element control. MCI instances are punched into the element node data if present, and provisions are made to invoke those callbacks, even though MCI itself no longer does any of this itself.

The immediate benefit is that Element widgets relying on MapbenderContainerInfo now behave properly in a buttons-style sidepane. Most prominently, Digitizer now correctly switches itself on and off. This was previously only possible in an accordion-style sidepane.

@werrolf werrolf merged commit 0e05061 into release/3.0.7 Feb 15, 2019
@werrolf werrolf deleted the fix/containerinfo-legacy-bridge branch February 15, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant