Skip to content
This repository has been archived by the owner on Oct 8, 2019. It is now read-only.

Notify about new devices signing in to AWS console #80

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

defvol
Copy link
Contributor

@defvol defvol commented Jun 8, 2016

See the discussion in #79

TODO

  • Add a new rule for the ConsoleLogin event
  • Add s3 permissions
  • Generate device ids
  • Persist ids in s3
  • Match current login against the s3 list of known devices
  • Fix matching regexp (should compare the full SHA hash not just a pattern)

Nice to have

  • Post to a slack channel
  • CC a sec group
  • Notify user through email

@defvol defvol changed the title [WIP] Notify when user logs in to AWS console from a new device [WIP] Notify about new devices signing in to AWS console Jun 8, 2016
@defvol
Copy link
Contributor Author

defvol commented Sep 2, 2016

@ianshward finally I've fixed the tests!

mind taking a look?

@defvol defvol changed the title [WIP] Notify about new devices signing in to AWS console Notify about new devices signing in to AWS console Sep 2, 2016
@defvol
Copy link
Contributor Author

defvol commented Sep 6, 2016

cc: @zmully you might be interested in this PR ^^
local tests are solid now

TL;DR this rule will trigger an event when a new device logs in. To keep a list of known devices, a SHA1 hash is generated and stored in a custom S3 bucket everytime a new device logs in.

@ianshward
Copy link
Member

This looks good to me @rodowi We're going to want to have some mechanism in patrol to do a notification to a non high priority pagerduty escalation policy, a message to a slack channel, or to an individual user, so that this does not page a main pagerduty escalation policy. That shouldn't prevent this from merging, but to deploy this, we'll want this alternative notification type in place. Ideally the notification mechanism used can be decided within the logic of rules (high, medium, low, or, pager, slack, personal email) and/or configurable when implementing the rules using lambda-cfn / in the cloudformation template.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants