Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence a spurious log at startup #9

Merged
merged 1 commit into from Jul 24, 2014
Merged

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Nov 1, 2013

The Application windows are expected to have a root view controller at the end of application launch message is logged if the overlay window doesn’t have a rootViewController property set.

@0xced
Copy link
Contributor Author

0xced commented Nov 1, 2013

Ha, I should have looked at the pull requests first because #8 is a duplicate! I’m not sure what approach is the best between the two though.

@0xced
Copy link
Contributor Author

0xced commented Feb 5, 2014

It turns out this may have very bad consequences on rotation. With this empty root view controller I was able to get the status bar to rotate without having any other view to rotate. :-/

I think it definitely needs more investigation before being merged.

By delaying the creation of the overlay window until touch events happen the "Application windows are expected to have a root view controller at the end of application launch" message is not logged anymore.
@0xced
Copy link
Contributor Author

0xced commented Apr 9, 2014

I just force-pushed the no-spurious-log branch with a better way to silence the warning. This is now safe to merge.

incanus added a commit that referenced this pull request Jul 24, 2014
Silence a spurious log at startup
@incanus incanus merged commit 46b054f into mapbox:master Jul 24, 2014
@0xced 0xced deleted the no-spurious-log branch July 25, 2014 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants