Identify Middleware #184
Merged
Identify Middleware #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a very simple login page to be redirected to in case the user is not authenticated |
miccolis
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
This looks reasonable to me, with two caveats;
- I think use http Basic auth is a great first step and solid utility auth method, but it demands a secured context; ie HTTPS, or a closed network. We should consider documenting this.
- We should do a comprehensive review of the cache headers (or lack thereof) for authenticated endpoints and make sure they make sense for contexts where Hecate is deployed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add a middleware to ensure that all access to a given hecate stack is authenticated, and if not, to redirect the user to a login portal
cc/ @ingalls