Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing of errorHandler #175

Merged
merged 3 commits into from
Jan 29, 2019
Merged

fix missing of errorHandler #175

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bd90f2
fix missding of errorHandler
beforeold Jan 21, 2019
51300ab
fix sytax for test case
beforeold Jan 22, 2019
ef02939
another way to cast the error
beforeold Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion MapboxGeocoder/MBGeocoder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,15 @@ open class Geocoder: NSObject {
request.setValue(userAgent, forHTTPHeaderField: "User-Agent")
return URLSession.shared.dataTask(with: request) { (data, response, error) in

guard let data = data else { return }
guard let data = data else {
if let e = error as NSError? {
errorHandler(e)
} else {
let unexpectedError = NSError(domain: MBGeocoderErrorDomain, code: -1024, userInfo: [NSLocalizedDescriptionKey : "unexpected error", NSDebugDescriptionErrorKey : "this error happens when data task return nil data and nil error, which typically is not possible"])
errorHandler(unexpectedError)
}
return
}
let decoder = JSONDecoder()

do {
Expand Down