Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch error handler on main queue #184

Merged
merged 1 commit into from Mar 27, 2019
Merged

Dispatch error handler on main queue #184

merged 1 commit into from Mar 27, 2019

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Mar 27, 2019

This is a followup to #175 that dispatches the error handler on the main thread, avoiding undefined behavior if Geocoder.geocode(_:completionHandler:) is called on a background thread.

/cc @frederoni @kbauhaus

@1ec5 1ec5 added the bug label Mar 27, 2019
@1ec5 1ec5 self-assigned this Mar 27, 2019
@1ec5 1ec5 requested a review from frederoni March 27, 2019 22:39
Copy link
Contributor

@JThramer JThramer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@1ec5 1ec5 merged commit e786dc4 into master Mar 27, 2019
@1ec5 1ec5 deleted the 1ec5-error-dispatch branch March 27, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants