Fix appearance of search inputs on mobile Safari #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,6 +59,7 @@ | |||
| } | |||
| .input[type='search'] { | |||
| appearance: textfield; | |||
| -webkit-appearance: none; | |||
There was a problem hiding this comment.
appearance and -webkit-appearance clash here: -webkit-appearance is populated by Autoprefixer when we use appearance. So if you think none is a better value, we should just use appearance: none.
There was a problem hiding this comment.
This was a facepalm moment, I fixed! I would expect that this would fix the other Safari input bug #540 but it did not 👎
dasulit
force-pushed
the
safari-bug-fixes
branch
from
74ba818
to
01c4384
Compare
dasulit
changed the title
|
I incorporated this fix into #577. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding
-webkit-appearance: noneto search inputs fixes #541I'm continuing to investigate other Safari bugs, but we can merge for beta if we want.