update homepage, add html template #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I edited the copy and layout on the home page a little in addition to adding the html template. I found all the |
| <script async defer src='https://api.mapbox.com/mapbox-assembly/v0.2.0/assembly.js'></script> | ||
| </head> | ||
| <body> | ||
| <!-- page content goes here --> |
There was a problem hiding this comment.
How about Your page ...
| <title><!-- Your title goes here --></title> | ||
| <meta charset='utf-8'> | ||
| <meta name='viewport' content='width=device-width, initial-scale=1'> | ||
| <link rel='shortcut icon' href='/path/to/favicon' type='image/x-icon'> |
There was a problem hiding this comment.
Should we say href='Your favicon path goes here' to make it more clear that this is another fill-in-the-black situation?
| @@ -146,7 +164,7 @@ class Home extends React.Component { | |||
| For dynamic styles, responsive classes (described above) provide some additional flexibility. | |||
| But if you need even more, you should use custom CSS instead of a utility class. | |||
| </p> | |||
| <h3 className='mt24 txt-bold'> | |||
| <h3 className='mt48 txt-bold'> | |||
| <code className='txt-code'>is-active</code> applies active states | |||
There was a problem hiding this comment.
Did you intend to remove the code from this? Aren't you disoriented?
There was a problem hiding this comment.
I couldn't think of a non-awkward way to re-write this one!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.